fix(TMCU-801): replace GlobalAlert with MMDS toast#32914
fix(TMCU-801): replace GlobalAlert with MMDS toast#32914georgewrmarshall wants to merge 5 commits into
Conversation
…okens Replace overlay.* scrim tokens in GlobalAlert with elevated surface and semantic text/icon colors for pure-black dark mode compatibility. Remove legacy importedColors usage from SimpleNotification. Add Storybook stories and unit tests for both components. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32914 +/- ##
==========================================
+ Coverage 84.41% 84.46% +0.04%
==========================================
Files 5976 5991 +15
Lines 156931 157402 +471
Branches 38183 38283 +100
==========================================
+ Hits 132481 132951 +470
+ Misses 15303 15285 -18
- Partials 9147 9166 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Remove the Redux-backed GlobalAlert stack and migrate call sites to toast(). Mount a single root Toaster in a full-screen overlay so toasts render above navigation, and revert unrelated SimpleNotification story changes from scope. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Remove GlobalAlert and SimpleNotification story entries that no longer have corresponding story files after the toast migration. Co-authored-by: Cursor <cursoragent@cursor.com>
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |





Description
This PR fixes pure-black dark mode feedback for clipboard and network-change alerts (TMCU-801) by removing the legacy
GlobalAlertstack and migrating call sites to the design-systemtoast()API.Why:
GlobalAlertrelied on scrim/overlay tokens that collapse visually in pure-black dark mode, making success and warning banners hard to read.What changed:
GlobalAlert, thealertRedux action/reducer, and related persist/test wiring<Toaster />inRootinside a full-screen overlay so toasts render above navigationGlobalAlertcall sites totoast():switchNetwork.ts)NftDetails.tsx)AccountOverview(dead code, updated for consistency)<Toaster />instances from Multichain Accounts screensSimpleNotificationstory/test changes;storybook.requires.jsmatchesmainChangelog
CHANGELOG entry: null
Related issues
Fixes: TMCU-801
Manual testing steps
Screenshots/Recordings
After screenshots (pure black dark mode, 350px width) are on the Files changed tab as inline file comments:
app/components/Views/NftDetails/NftDetails.tsxapp/util/networks/switchNetwork.tsImages: https://github.com/MetaMask/metamask-mobile/tree/screenshots/visual-regression/pr-32914/after
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an examplePre-merge reviewer checklist